Move remaining credentials module to shared library #3979
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change moves remaining credentials module after [this pull request] to the shared library. This is needed for ECS frontend, EC2 client, ECR factory. Usages in
agent/
have been accordingly updated.Implementation details
agent/credentials/instancecreds
toecs-agent/credentials/instancecreds
andagent/credentials/providers
toecs-agent/credentials/providers
seelog
withlogger
go mod init && go mod vendor
ran inecs-agent
andagent
directories.amazon-ecs-agent/ecs-agent/credentials
now looks like:Testing
make test
andmake run-integ-tests
New tests cover the changes: No new behavior is being introduced, so existing testing should suffice.
Description for the changelog
Move instance credentials and credential provider to shared library
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.